Mark HTTP/1 trailer headers as unsupported on Browser#124466
Merged
Conversation
Member
|
@copilot See the comment #54156 (comment) Do not try to implement the feature. Just replace the ActiveIssue attribute on the SocketsHttpHandler_Http1_TrailingHeaders_Test with a platform not supported for browser. |
github-actions
bot
added
the
needs-area-label
…n Browser Co-authored-by: oroztocil <79744616+oroztocil@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement trailer headers for HTTP handling
Mark HTTP/1 trailer headers as unsupported on Browser
Feb 16, 2026
github-actions
bot
added
area-System.Net.Http
and removed
needs-area-label
oroztocil
requested changes
Feb 16, 2026
src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
Outdated
Show resolved
Hide resolved
…support Co-authored-by: oroztocil <79744616+oroztocil@users.noreply.github.com>
akoeplinger
approved these changes
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates System.Net.Http functional tests to reflect that HTTP/1 trailer headers are a Browser platform limitation rather than an active product issue.
Changes:
- Replaced
ActiveIssuewithSkipOnPlatformfor the HTTP/1 trailing headers test on Browser. - Updated the skip message to clarify that most major browsers don’t support HTTP/1 trailers.
oroztocil
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HTTP/1 trailer headers are not implemented for Browser platform. Changed test attribute from
ActiveIssuetoSkipOnPlatformto reflect this is a permanent platform limitation, not a tracked bug.Changes
[ActiveIssue("https://github.com/dotnet/runtime/issues/54156", TestPlatforms.Browser)]with[SkipOnPlatform(TestPlatforms.Browser, "HTTP/1 trailers are not supported by most major browsers")]onSocketsHttpHandler_Http1_TrailingHeaders_TestThis aligns with the pattern used for other Browser platform limitations (proxies, certificates, sockets). The skip message clarifies that this is a browser limitation affecting HTTP/1 trailers specifically, not a .NET implementation issue.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.